switch to ubuntu trusty 14.04#2289
Closed
Fahad-Alsaidi wants to merge 10 commits intopython-pillow:masterfrom
Closed
switch to ubuntu trusty 14.04#2289Fahad-Alsaidi wants to merge 10 commits intopython-pillow:masterfrom
Fahad-Alsaidi wants to merge 10 commits intopython-pillow:masterfrom
Conversation
Contributor
Author
|
I need help to fix this: |
wiredfool
reviewed
Dec 15, 2016
| # There is a known error in it: TypeError: PyPy does not yet implement the new buffer interface (issue #2163). | ||
|
|
||
| SKIP_5_4_1_PYPY = hasattr(sys, 'pypy_version_info') and ( | ||
| sys.pypy_version_info >= (5, 4, 1, 'final', 0)) |
Member
There was a problem hiding this comment.
Lets make this a little tighter -- either just 5.4.1 or 5.4.0 < v <5.4.1.
The default case should be that we have to reaffirm this skip for each pypy that fails, not that we never run these tests again.
Member
|
The getargs thing is a real bug in the C layer, it's not an issue with changing the test. I'll have to track that one down. |
Member
|
Ok, I was wrong, that's the same underlying issue. I've confirmed that there's a regression in pypy 5.4 and 5.6, where it worked in 5.3. There's a workaround in #2294. |
Member
|
Closed in favor of #2294 |
Member
|
Merged via PR #2294. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required for Adding CTL support #2284.