Skip to content

switch to ubuntu trusty 14.04#2289

Closed
Fahad-Alsaidi wants to merge 10 commits intopython-pillow:masterfrom
Fahad-Alsaidi:trusty
Closed

switch to ubuntu trusty 14.04#2289
Fahad-Alsaidi wants to merge 10 commits intopython-pillow:masterfrom
Fahad-Alsaidi:trusty

Conversation

@Fahad-Alsaidi
Copy link
Contributor

This required for Adding CTL support #2284.

@Fahad-Alsaidi
Copy link
Contributor Author

I need help to fix this:

======================================================================

ERROR: TestImagePath.test_path

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/python-pillow/Pillow/Tests/test_imagepath.py", line 62, in test_path

    p = ImagePath.Path(tuple(arr.tostring()))

SystemError: new style getargs format but argument is not a tuple

# There is a known error in it: TypeError: PyPy does not yet implement the new buffer interface (issue #2163).

SKIP_5_4_1_PYPY = hasattr(sys, 'pypy_version_info') and (
sys.pypy_version_info >= (5, 4, 1, 'final', 0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make this a little tighter -- either just 5.4.1 or 5.4.0 < v <5.4.1.

The default case should be that we have to reaffirm this skip for each pypy that fails, not that we never run these tests again.

@wiredfool
Copy link
Member

wiredfool commented Dec 15, 2016

The getargs thing is a real bug in the C layer, it's not an issue with changing the test. I'll have to track that one down.

@wiredfool
Copy link
Member

Ok, I was wrong, that's the same underlying issue.

I've confirmed that there's a regression in pypy 5.4 and 5.6, where it worked in 5.3. There's a workaround in #2294.

@wiredfool
Copy link
Member

Closed in favor of #2294

@wiredfool wiredfool closed this Dec 20, 2016
@hugovk
Copy link
Member

hugovk commented Dec 21, 2016

Merged via PR #2294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants