-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Test support for centos/amazon linux #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c2104a5 to
8c49b8f
Compare
docs/reference/ImageDraw.rst
Outdated
| :param spacing: The number of pixels between lines. | ||
| :param align: "left", "center" or "right". | ||
| :param direction: Direction of the text. It can be 'rtl', 'ltr', 'ttb' or 'btt'. Requires libraqm. | ||
| :param features: A list of font feature to be used during text layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font features?
docs/reference/ImageFont.rst
Outdated
| mode. Note that the mode is always a string, to simplify | ||
| C-level implementations. | ||
| :param direction: Direction of the text. It can be 'rtl', 'ltr', 'ttb' or 'btt'. Requires libraqm | ||
| :param features: A list of font feature to be used during text layout. This is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is built on the complex text pr, because I'd been hacking in the test_imagefont stuff, and splitting the patches was going to be hairy and unnecessary.
|
|
||
| from PIL import ImageChops | ||
|
|
||
| ImageChops.difference(im, target_img).save('multiline.png') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this debug file output leaved by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Sigh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has now been addressed by PR #2623
This is test support on docker for centos/amazon linux.
It's parameterizing changes in test_imagefont.py, but unfortunately that is a really messy diff built from the complex text changes. So this has #2576 as a dependency.