Pass the correct types to PyArg_ParseTuple#3880
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Jun 28, 2019
Merged
Conversation
Py_ssize_t uses the 'n' specifier, not 'i'.
Contributor
Author
|
I'm not sure what this segfault in CI is about, but it seems to be affecting other PRs, so I'm not sure if it's related or not. |
Contributor
Author
|
Oh, I just realized that #3840 is ppc64, not ppc64le, i.e., big-endian. So this should fix it too. |
radarhere
changed the title
Member
|
To create a link, comments were originally made about this in #3749 |
Contributor
Author
|
So we've now built several packages (that previously failed) using this patch, so I'm pretty sure this works. It's just a matter of which way you'd like to go with the change. |
hugovk
approved these changes
Jun 27, 2019
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Let's merge this for the next release if no objections.
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_ssize_tuses the 'n' specifier, not 'i'. IfPy_ssize_tis bigger thanint, this can be fine on little-endian systems but is very broken on big-endian systems as values end up 2**32 times bigger.The previous change was a bit inconsistent and only changed
src/encode.c, but notsrc/decode.c, so I'm not sure if I should have gone the other way and reverted theint->Py_ssize_tchange instead.Fixes #3841.
Fixes #3840.