No more deprecated bdist_wininst .exe installers#4029
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Sep 5, 2019
Merged
No more deprecated bdist_wininst .exe installers#4029hugovk merged 1 commit intopython-pillow:masterfrom
hugovk merged 1 commit intopython-pillow:masterfrom
Conversation
Member
|
I’m pretty sure that is just in there for the build artifacts on windows. I don’t think @cgohlke uses the winbuild bits for the actual releases. |
Contributor
Those files are produced by my build script, which simply runs +1 for dropping |
Merged
19 tasks
Member
|
See also #2832 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bdist_wininst(.exeinstallers) has been deprecated in Python 3.8, andbdist_wheel(wheel packages) should be used instead:As far as I can see in the codebase, it's only used in
build.py --distto create Windows installers for testing dev builds. There's already abuild.py --wheeloption forbdist_wheelpackages. So let's remove--dist.In https://discuss.python.org/t/deprecate-bdist-wininst/1929/12?u=hugovk, @cgohlke pointed out:
@cgohlke Are those
.exeinstallers something you normally send over each release day? If so, we can just skip those.Any objections to stop distributing
.exeinstallers for the next release?Here's the output of
pypinfo --limit 10 pillow file, showing the download count for the Pillow files on PyPI over the last 30 days:Served from cache: True
Data processed: 0.00 B
Data billed: 0.00 B
Estimated cost: $0.00
And
pypinfo --limit 1000 pillow file, contains no.exeand the last 56 rows are all for a single download.