Test ImageShow.show on CIs#4074
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Sep 21, 2019
Merged
Conversation
b57a4af to
d7c57bf
Compare
hugovk
approved these changes
Sep 21, 2019
Member
hugovk
left a comment
There was a problem hiding this comment.
Can we also run it on Azure Pipelines?
| CI | env vars |
|---|---|
| AppVeyor | CI, APPVEYOR |
| Azure Pipelines | TF_BUILD |
| Travis CI | CI, CONTINUOUS_INTEGRATION, TRAVIS |
There's no similar env var for GitHub Actions yet, it's been requested here:
Perhaps add an on_ci() that checks for CI and TF_BUILD? Then if GHA adds CI it'll be covered.
d7c57bf to
b8a15f2
Compare
b8a15f2 to
508a2b4
Compare
Member
Author
|
Okay, done. |
Contributor
|
Note, that on Windows this will always either succeed (AppVeyor), or hang (GitHub Actions). It can't fail, even if there is no application associated with the file format. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test that actually runs the
ImageShow.showmethod, opening the image. However, to be neat, it only runs on the CIs, where the shown images won't bother users.