Avoid using pkg_resources in PIL.features.pilinfo#4975
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Oct 14, 2020
Merged
Avoid using pkg_resources in PIL.features.pilinfo#4975hugovk merged 1 commit intopython-pillow:masterfrom
hugovk merged 1 commit intopython-pillow:masterfrom
Conversation
Member
|
Yep, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
pkg_resources, which AFAICT is part ofsetuptools, check the LCMS version (check added in #4963) manually.While
setuptoolsis very likely to already be installed, Pillow doesn't actually require it for runtime, only compilation and testing. Additionally, thepilinfofunction is useful for finding configuration issues and should have as few external dependencies as possible.Since this version string is being set in the C code, it is safe to break it back into ints and perform a tuple comparison instead.
This PR also adds a comment to make sure the two checks don't get out of sync.