init() if one of the formats is unrecognised#5037
Merged
hugovk merged 1 commit intopython-pillow:masterfrom Nov 11, 2020
Merged
init() if one of the formats is unrecognised#5037hugovk merged 1 commit intopython-pillow:masterfrom
hugovk merged 1 commit intopython-pillow:masterfrom
Conversation
Member
|
Can this be tested too? |
Member
Author
|
The key part of the change here is causing a module to be imported, so that Pillow/src/PIL/WebPImagePlugin.py Line 345 in 2d6e51e The problem is that conftest Lines 4 to 9 in 2d6e51e calls Lines 216 to 230 in 2d6e51e So the plugins are already imported. I'm not seeing a way to re-import a Python module. I think it would be possible to mock a plugin, but I feel like that would be overly complex. |
Member
|
Okay, thanks! |
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5036
Image.opencallspreinit()first and then expects to loop through them. However,formatsoverrides this, and soWEBPis checked, which throws aKeyErrorbecauseinit()has not been called yet, asImage.open()only calls it if thepreinit()formats do not match.This PR resolves that.