Updated default value for SAMPLESPERPIXEL TIFF tag#5452
Merged
hugovk merged 1 commit intopython-pillow:masterfrom May 14, 2021
Merged
Updated default value for SAMPLESPERPIXEL TIFF tag#5452hugovk merged 1 commit intopython-pillow:masterfrom
hugovk merged 1 commit intopython-pillow:masterfrom
Conversation
This was referenced Apr 29, 2021
Contributor
|
@radarhere This is from #5364 (comment) (and next comment). |
Contributor
|
Perhaps less risky solution would be to handle OJPEG compressed images with special hacks around missing tags like LibTiff does https://gitlab.com/libtiff/libtiff/-/blob/master/libtiff/tif_dirread.c#L4081 |
ce87dcc to
ea033f4
Compare
Member
Author
|
Thanks for reviewing. I've updated the commit with your suggestion. |
ea033f4 to
6fc039a
Compare
kkopachev
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5317
#5372 added this code, to raise an error when opening a TIFF image if the SAMPLESPERPIXEL didn't match the number of bits per sample - or if it were missing and the bits per sample wasn't 1.
Pillow/src/PIL/TiffImagePlugin.py
Lines 1253 to 1255 in ef9a8e5
This PR relaxes that, to allow through images where SAMPLESPERPIXEL is missing. I created a test image by just commenting out SAMPLESPERPIXEL when saving a TIFF.
Ping @wiredfool in case there was a reason for this that I'm not aware of.