Deprecate ImagePalette size parameter#5641
Merged
mergify[bot] merged 2 commits intopython-pillow:masterfrom Jul 29, 2021
Merged
Deprecate ImagePalette size parameter#5641mergify[bot] merged 2 commits intopython-pillow:masterfrom
mergify[bot] merged 2 commits intopython-pillow:masterfrom
Conversation
hugovk
approved these changes
Jul 29, 2021
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Jul 31, 2021
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Jul 31, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5636
The
sizeparameter was originally added in #537. Before #5552, it was there to override a default length check.Pillow/src/PIL/ImagePalette.py
Lines 45 to 48 in 10615a7
Afterwards though, the default length check was gone, so
sizeis now just adding an arbitrary constraint on the user - if provided, it throws an error ifpaletteparameter is not the length of thesizeparmeter.Pillow/src/PIL/ImagePalette.py
Lines 43 to 44 in 3462b5f