Fixed BUFR, GRIB and HDF5 stub saving#6071
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Feb 19, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pillow/src/PIL/BufrStubImagePlugin.py
Lines 62 to 63 in af34535
hasattr("_handler", "save")is incorrect. We are not interested if the string"_handler"has asaveattribute, we are interested if the variable_handlerhas a save attribute.This was fixed for WmfStubImageFile in 751a6d1c2d13144e240ac2, but the fix wasn't applied to other stub formats.
I have not applied this fix to FITS, as the stub form of that plugin is being deprecated in #6056