Skip to content

Add xfail mark to TestEmbeddable #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radarhere merged 3 commits into from
Oct 30, 2022
Merged

Add xfail mark to TestEmbeddable #6703

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaee7fd
add xfail mark to test_image_access:test_embeddable
nulano Oct 30, 2022
181fad2
move import used only on Windows and remove unused import
nulano Oct 30, 2022
23df3bd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions Tests/test_image_access.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@
import sysconfig

import pytest
from setuptools.command.build_ext import new_compiler

from PIL import Image

from .helper import assert_image_equal, hopper, is_win32, on_ci
from .helper import assert_image_equal, hopper, is_win32

# CFFI imports pycparser which doesn't support PYTHONOPTIMIZE=2
# https://github.com/eliben/pycparser/pull/198#issuecomment-317001670
Expand Down Expand Up @@ -406,14 +405,13 @@ def test_putpixel_unrecognized_mode(self):


class TestEmbeddable:
@pytest.mark.skipif(
not is_win32() or on_ci(),
reason="Failing on AppVeyor / GitHub Actions when run from subprocess, "
"not from shell",
)
@pytest.mark.xfail(reason="failing test")
@pytest.mark.skipif(not is_win32(), reason="requires Windows")
def test_embeddable(self):
import ctypes

from setuptools.command.build_ext import new_compiler

with open("embed_pil.c", "w", encoding="utf-8") as fh:
fh.write(
"""
Expand Down