Added IFD enum to ExifTags#6748
Merged
radarhere merged 5 commits intopython-pillow:mainfrom Dec 13, 2022
Merged
Conversation
hugovk
approved these changes
Dec 13, 2022
This was referenced Dec 28, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps #6641 by adding "named constants for common IFDs".
Adds the following to ExifTags.
I updated other parts of Pillow's code to use these new constants internally. In doing so, I found
Pillow/src/PIL/Image.py
Line 3618 in df8e872
I can only imagine that
0x8225was a typo when I added it in 4b14f01, so I'm removing it here.Resolves #6777 by adding
IFD.IFD1as well, so that IFD1 data can be read, and then modifyingget_child_images()to make use of IFD1 data to read thumbnails through the "ThumbnailOffset in IFD1".