Remove redundant wheel dep from pyproject.toml#7248
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Jul 2, 2023
Merged
Remove redundant wheel dep from pyproject.toml#7248hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
Remove the redundant `wheel` dependency, as it is added by the backend automatically. Listing it explicitly in the documentation was a historical mistake and has been fixed since, see: pypa/setuptools@f7d30a9 While Pillow uses a custom backend that modifies the `bdist_wheel` method, it does not import `wheel` or use it in a way that would rely on setuptools implementation details.
radarhere
approved these changes
Jul 2, 2023
Member
|
Thanks. I was looking at https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/#fallback-behaviour when I added this in #7171 |
Contributor
Author
|
Thanks. I'll look into having an appropriate warning added there. |
Contributor
Author
|
Thanks again! I've filed pypa/pip#12122 to update pip documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
wheeldep frompyproject.tomlRemove the redundant
wheeldependency, as it is added by the backend automatically. Listing it explicitly in the documentation was a historical mistake and has been fixed since, see: pypa/setuptools@f7d30a9While Pillow uses a custom backend that modifies the
bdist_wheelmethod, it does not importwheelor use it in a way that would rely on setuptools implementation details.