Corrected drawing I;16 points and writing I;16 text#7257
Merged
hugovk merged 2 commits intopython-pillow:mainfrom Oct 5, 2023
Merged
Corrected drawing I;16 points and writing I;16 text#7257hugovk merged 2 commits intopython-pillow:mainfrom
hugovk merged 2 commits intopython-pillow:mainfrom
Conversation
homm
reviewed
Jul 10, 2023
homm
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7245
As the issue explains,
Pillow/src/libImaging/Draw.c
Lines 68 to 75 in be828f4
is just drawing the writing the same value to two different points in our 8-bit image, whereas the point of 16-bit images is that each of those 2 8-bit values should be different.
This fixes that. It also means that the test from #3899 is slightly changed. The important part of that test was the width of the rectangle, which is maintained here.
The issue also requested a similar change for writing text, so I've added that commit for that.