Lock around usages of imaging memory arenas#8238
Merged
hugovk merged 8 commits intopython-pillow:mainfrom Aug 1, 2024
Merged
Conversation
14 tasks
Yay295
reviewed
Jul 16, 2024
nulano
reviewed
Jul 16, 2024
Contributor
Author
|
This is ready to be reviewed more throughly. All tests pass and tsan is happy. |
Contributor
Out of curiosity, how are you testing with tsan? I don't think we have it in CI (although perhaps we should add it!). |
Contributor
Author
I added a few very very basic threaded tests, built CPython and Pillow with tsan enabled and then ran the tests. It all takes forever, cause CPython with tsan is very slow, but it works. If your question is how I build Pillow with tsan enabled, it is really easy: |
hugovk
approved these changes
Jul 20, 2024
Member
|
If no other reviews or comments, I'll merge this tomorrow. |
Member
|
Thanks @lysnikolaou! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8199.
Did some testing with threads. Thread-sanitizer is also happy after these changes.