Handle rational tags with a zero denominator#8475
Closed
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Closed
Handle rational tags with a zero denominator#8475radarhere wants to merge 1 commit intopython-pillow:mainfrom
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Conversation
Member
Author
|
After fixing the type hint errors in #8474, the ZeroDivisionError starts occurring there. So that PR can replace this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8471
When adding type hints in #8270, I added a cast to
float.Pillow/src/PIL/TiffImagePlugin.py
Lines 294 to 297 in 11c654c
However, that is causing a ZeroDivisionError when the value is an IFDRational with a denominator of zero.
I'm able to remove the cast without causing a mypy error, so I've reverted that specific change.
I created a test image with