Use fixture to re-open image for each JPEG2000 test#8484
Merged
radarhere merged 2 commits intopython-pillow:mainfrom Oct 26, 2024
Merged
Use fixture to re-open image for each JPEG2000 test#8484radarhere merged 2 commits intopython-pillow:mainfrom
radarhere merged 2 commits intopython-pillow:mainfrom
Conversation
hugovk
approved these changes
Oct 26, 2024
Tests/test_file_jpeg2k.py
Outdated
| test_card.load() | ||
|
|
||
| @pytest.fixture | ||
| def test_card() -> Generator[ImageFile.ImageFile, None, None]: |
Member
There was a problem hiding this comment.
Good idea!
I know the old one was also prefixed test_, but that makes it look like a test function. Maybe just card?
Suggested change
| def test_card() -> Generator[ImageFile.ImageFile, None, None]: | |
| def card() -> Generator[ImageFile.ImageFile, None, None]: |
Member
Author
There was a problem hiding this comment.
Sure, I've pushed a commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the start of test_file_jpeg2k.py, an image is opened.
Pillow/Tests/test_file_jpeg2k.py
Lines 32 to 33 in d59b169
It is then used throughout the tests.
Pillow/Tests/test_file_jpeg2k.py
Lines 103 to 110 in d59b169
Rather than re-using the same image instance throughout the tests, and allowing it to be potentially modified in one test and affect all subsequent tests, this PR uses a fixture to re-open it each time, following the style of test_image_resize.py.