Added reading of J2K comments#8622
Merged
hugovk merged 2 commits intopython-pillow:mainfrom Dec 28, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6909 added reading of JP2 comments. This adds reading of J2K comments as well.
JP2 comments are read from a "Contiguous codestream box" that "contains a valid and complete JPEG 2000 codestream"
Pillow/src/PIL/Jpeg2KImagePlugin.py
Lines 264 to 265 in 0e3f51d
and starts by skipping
hdr.Pillow/src/PIL/Jpeg2KImagePlugin.py
Lines 298 to 301 in 0e3f51d
Reading from a J2K image,
Pillow/src/PIL/Jpeg2KImagePlugin.py
Lines 252 to 254 in 0e3f51d
the
hdris already read.Pillow/src/PIL/Jpeg2KImagePlugin.py
Lines 101 to 107 in 0e3f51d
So this PR moves the
hdrhandling out of_parse_comment.