Only crop GIF frames when saving with disposal method 2 if transparency is present#8748
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Feb 17, 2025
Merged
Only crop GIF frames when saving with disposal method 2 if transparency is present#8748hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8746
When GIF frames are saved, Pillow crops out parts of frames i order to save space.
In #5557, I found https://legacy.imagemagick.org/Usage/anim_basics/#dispose. In the 'Dispose Background' section (a.k.a. disposal method 2), it states that
So there is apparently a convention to clear to transparency for disposal method 2, rather than the background colour as described by the specification. The new issue has found this to be a problem with our saved GIFs.
To fix this, when saving with disposal method 2, this PR will only crop if there is transparency.