Merged
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.9.9 → v0.11.4](astral-sh/ruff-pre-commit@v0.9.9...v0.11.4) - [github.com/pre-commit/mirrors-clang-format: v19.1.7 → v20.1.0](pre-commit/mirrors-clang-format@v19.1.7...v20.1.0) - [github.com/python-jsonschema/check-jsonschema: 0.31.2 → 0.32.1](python-jsonschema/check-jsonschema@0.31.2...0.32.1) - [github.com/woodruffw/zizmor-pre-commit: v1.4.1 → v1.5.2](zizmorcore/zizmor-pre-commit@v1.4.1...v1.5.2) - [github.com/abravalheri/validate-pyproject: v0.23 → v0.24.1](abravalheri/validate-pyproject@v0.23...v0.24.1)
for more information, see https://pre-commit.ci
Member
|
New clang-format gave this error before, removing https://github.com/python-pillow/Pillow/actions/runs/14315399800/job/40120258457?pr=8873 |
Member
|
Investigating, I think clang is detecting some files as C++, and some as C. Looking at https://clang.llvm.org/docs/ClangFormatStyleOptions.html#clang-format-style-options, I think a way to specify both languages would be to list the options twice - radarhere@8b7d724 - but you might think that is unsightly. |
Member
|
If there's no way to force it to check as C, then that's fine by me, we don't need to change it too often. |
Member
|
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#language
So radarhere@05dea18 is another option. |
Member
|
Either fine with me :) |
radarhere
approved these changes
Apr 8, 2025
Member
radarhere
left a comment
radarhere
left a comment
There was a problem hiding this comment.
Ok, I've listed the options twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: