Do not call sys.executable in ImageShow in PyInstaller application#9028
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Jun 25, 2025
Merged
Do not call sys.executable in ImageShow in PyInstaller application#9028hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9027
The issue has reported that a PyInstaller application does not have a Python instance as
sys.executable- it has the application.https://pyinstaller.org/en/stable/runtime-information.html
This means that
Pillow/src/PIL/ImageShow.py
Lines 178 to 185 in ef0bab0
will not be able to delete the image, and might inadvertently launch the application a second time.
Using a check from https://pyinstaller.org/en/stable/runtime-information.html, this PR ignores
sys.executableif in a PyInstaller application.python3might still be used.