Skip to content

Add dbg image for development/debugging purposes#160

Merged
hugovk merged 2 commits intomainfrom
valgrind-improvements
Nov 5, 2022
Merged

Add dbg image for development/debugging purposes#160
hugovk merged 2 commits intomainfrom
valgrind-improvements

Conversation

@wiredfool
Copy link
Copy Markdown
Member

Provides a new docker image ubuntu-22.04-jammy-amd64-valgrind-dbg with debug symbols, source, and enough tools to track down extension issues that show up on the valgrind image.

@radarhere radarhere changed the title Add dbg image for development/debugging purposes. Add dbg image for development/debugging purposes Nov 3, 2022
libopenjp2-7-dbgsym \
libharfbuzz0b-dbgsym \
libfribidi0-dbgsym \
emacs-nox
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some cache cleanup in the others to keep the layers/images smaller (re: #91):

&& apt-get clean && rm -rf /var/lib/apt/lists/*

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as worried about size on this one, and there's much more of a possibility to need to inline add things to the image while working.

@radarhere
Copy link
Copy Markdown
Member

I'm unsure if this is deliberate or not - this hasn't been added to GitHub Actions?

@wiredfool
Copy link
Copy Markdown
Member Author

wiredfool commented Nov 4, 2022

No, not in GHA -- This is an incremental build off of the other one, and essentially local development stuff that I don't want to lose and be able to reference elsewhere. I'm actually thinking that this is more useful to build locally than to have in the actual saved docker images. Though, I'm not sure if the build will work properly if we're not logged into dockerhub, so might need to tweak the makefile a bit there.

Other thought -- this should probably be included here: https://github.com/python-pillow/Pillow/blob/main/docs/reference/c_extension_debugging.rst and some of the setup to make GDB work with the python stack should be done as well.

@hugovk hugovk merged commit e637483 into main Nov 5, 2022
@radarhere radarhere deleted the valgrind-improvements branch November 5, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants