Replace --no-cache-dir with PIP_NO_CACHE_DIR=1#212
Merged
radarhere merged 1 commit intopython-pillow:mainfrom Sep 9, 2024
Merged
Replace --no-cache-dir with PIP_NO_CACHE_DIR=1#212radarhere merged 1 commit intopython-pillow:mainfrom
--no-cache-dir with PIP_NO_CACHE_DIR=1#212radarhere merged 1 commit intopython-pillow:mainfrom
Conversation
Member
|
The 'wheel-build' job failures here would be fixed by python-pillow/Pillow#8293 |
Member
|
Rather than ignoring the warning, is there a reason we don't upgrade pip first? |
Member
Author
|
Hmm, we could do, although we're currently getting the warning here: docker-images/amazon-2-amd64/Dockerfile Lines 48 to 53 in 9bbc4de We only use system pip to install virtualenv, then we do upgrade pip inside the virtualenv before installing other stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
pip installcommands a bit shorter and easier to read.Also add
PIP_DISABLE_PIP_VERSION_CHECK=1, prevents warnings like this that sometimes shows up:Also use
ARGinstead ofENV:ARG- only available during the buildENV- also available inside the imagehttps://vsupalov.com/docker-arg-env-variable-guide/#arg-and-env
https://docs.docker.com/build/building/variables/