This repository was archived by the owner on Oct 8, 2024. It is now read-only.
Closed
Conversation
radarhere
reviewed
Apr 12, 2021
.gitmodules
Outdated
| [submodule "Pillow"] | ||
| path = Pillow | ||
| url = git://github.com/python-Pillow/Pillow.git | ||
| url = git://github.com/fdintino/Pillow.git |
Member
There was a problem hiding this comment.
I presume this is just temporary to demonstrate that the PR passes?
Author
There was a problem hiding this comment.
Yes, exactly. That's also why I made it a separate commit, so that it's easy to revert / rebase away.
radarhere
force-pushed
the
master
branch
2 times, most recently
from
d7cb6a8 to
49bd09a
Compare
Member
|
This has now been incorporated into python-pillow/Pillow#5201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion PR for python-pillow/Pillow#5201 (and python-pillow/pillow-depends#37). It adds scripts to build libavif wheels for manylinux1 and os x.
A few notes:
AOM required two changes to build on manylinux1—one to deal with the old version of perl, and another to
#definean intrinsic that has a different name in the glibc on el5.While I was working on these scripts I ran into some flakiness with crates.io. The recommended way to avoid such issues with rust CI builds is to "vendor" the crate dependencies. To that end, I included a rav1e vendor tar.gz file in python-pillow/pillow-depends#37. Also included in that PR is a script to generate new rav1e vendor archives. Despite the complexity building rav1e adds, I still think its inclusion is worthwhile because of how much faster it is compared to aom.
I'm not currently building rav1e on 32-bit because there are only 64-bit binaries for cargo-c releases. If this strikes folks as problematic, I could either look into opening a pull request against cargo-c to add 32-bit builds to their CI, or build cargo-c from source here (though I'd likely have to add a crate vendor tar.gz file for cargo-c to pillow-depends).
SVT-AV1 was too much of a hassle to build for manylinux1, though I am still building it for the os x wheels here. I'm open to removing this codec altogether.
In summary: all wheels include the aom codec for encoding and decoding, and the dav1d codec for decoding. 64-bit wheels include rav1e, and OS X has the SVT-AV1 codec.