This repository was archived by the owner on Oct 8, 2024. It is now read-only.
Fixed setting MACOSX_DEPLOYMENT_TARGET#282
Merged
radarhere merged 1 commit intopython-pillow:mainfrom Apr 8, 2022
Merged
Conversation
Member
Author
|
Regarding python-pillow/Pillow#6179 (comment), if there is a preference to drop support for earlier macOS versions, I have no objections to that. But that was not the intention for #265, and the deployment target code should either be fixed or removed. |
Member
|
I'm fine with this, it was an unintentional change and simple enough to fix. We could consider intentionally dropping them at some point, especially if there's some maintenance benefit for doing so. Thanks! |
hugovk
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves python-pillow/Pillow#6179
If you look at the artifacts generated before #265, in https://github.com/python-pillow/pillow-wheels/actions/runs/2008816167 you see Pillow-9.0.1-cp38-cp38-macosx_10_10_x86_64.whl.
After that PR, in https://github.com/python-pillow/pillow-wheels/actions/runs/2011383640 you see Pillow-9.0.1-cp38-cp38-macosx_10_9_x86_64.whl.
So despite the fact that the PR was only intended to rearrange the jobs, there was a change. This is because in moving
MACOSX_DEPLOYMENT_TARGET, I managed to break it. This is fixed here usingexport, and you can see that this PR generates Pillow-9.1.0-cp38-cp38-macosx_10_10_x86_64.whl again.