completions: bash template does not handle sub-commands

[abn]

$ poetry --version
Poetry (version 1.2.0b2dev0)
$ echo $BASH_VERSION
5.1.16(1)-release
$ poetry completions bash | bash
bash: line 40: syntax error near unexpected token `clear'
bash: line 40: `            (cache clear)'

Originally reported at python-poetry/poetry#4572.

[ByteCommander]

Facing the same issue on Ubuntu (18.04) with Bash 4.4 and current Poetry 1.2.

$ poetry --version
Poetry (version 1.2.0)

$ echo $BASH_VERSION
4.4.20(1)-release

The generated poetry completions bash script is syntactically invalid, because I believe the pattern inside a Bash case check must only be a single word, therefore patterns including spaces must be quoted.

Broken, as generated by Poetry currently (excerpt, lines numbered):

26          case "$com" in
...
40              (cache clear)
41              opts="${opts} --all"
42              ;;
...
180          esac

Manually fixed line (apply to all other case patterns with spaces as well):

40              ("cache clear")

[pdecat]

Same issue on Ubuntu 22.10 with bash 5.1.16 and poetry 1.2.0.

Using \ before spaces also works as a work-around, e.g. (cache\ clear):

diff --git a/cleo/commands/completions_command.py b/cleo/commands/completions_command.py
index ab73aba..1f2be42 100644
--- a/cleo/commands/completions_command.py
+++ b/cleo/commands/completions_command.py
@@ -161,8 +161,9 @@ script. Consult your shells documentation for how to add such directives.
                 f"--{opt.name}".replace(":", "\\:")
                 for opt in sorted(cmd.definition.options, key=lambda o: o.name)
             )
+            cmd_name = cmd.name.replace(' ', '\\ ')
             cmds_opts += [
-                f"            ({cmd.name})",
+                f"            ({cmd_name})",
                 f'            opts="${{opts}} {options}"',
                 "            ;;",
                 "",  # newline

Edit: please note that completion for sub-commands does not work with this work-around.

[Secrus]

This is acknowledged, and I plan to work on the fix when time allows. It is on the to-do list with very high priority.

[neersighted]

Please open as new issue for ZSH issues, if there is not already one. This issue is only for tracking incorrectly generated bash completions.