Rename custom exceptions form *Exception to *Error #179
Rename custom exceptions form *Exception to *Error #179neersighted merged 1 commit intopython-poetry:mainfrom
Conversation
|
nb this is a breaking change. If you're going to make breaking changes, it's worth considering more cleanup than this.
I realise that you were likely just looking to do a small tidy-up and not get into all this. But breaking changes should be rare: and if you're going to make breaking changes anyway, then that's the opportunity to make such improvements. |
Thanks for your input, I appreciate it. I will look into what you pointed out. I am aware that those are breaking changes, but as far as I know, the next release is gonna be 1.0.0 which could be a good point to introduce such changes, especially since we are working towards better code quality with more flake8 checks and the introduction of type checking via mypy. |
7bac59a to
0109854
Compare
0109854 to
5154d66
Compare
5154d66 to
6480f3b
Compare
Resolves: #162