Skip to content

chore(utils): add types#209

Closed
branchv wants to merge 1 commit intopython-poetry:masterfrom
branchv:mypy/utils
Closed

chore(utils): add types#209
branchv wants to merge 1 commit intopython-poetry:masterfrom
branchv:mypy/utils

Conversation

@branchv
Copy link
Copy Markdown
Member

@branchv branchv commented Jul 27, 2022

No description provided.

Comment thread cleo/_utils.py


def format_time(secs: float) -> str:
def format_time(secs: float) -> str: # type: ignore[return]
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is getting fixed + refactored in #122, so just ignoring

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anddd i just realized i duplicated some of that pr, oops

Comment thread cleo/_utils.py Outdated
Copy link
Copy Markdown
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave the decision up to you, whether to merge it and just fill in the blanks with #122 or to leave it and let the other PR be "first".

@branchv
Copy link
Copy Markdown
Member Author

branchv commented Jul 28, 2022

yea i'll close this for now, can always reopen if the other PR stalls out

@branchv branchv closed this Jul 28, 2022
@branchv branchv deleted the mypy/utils branch July 28, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants