fix: gracefully handle SIGPIPE#236
Merged
Secrus merged 1 commit intopython-poetry:mainfrom Sep 2, 2022
branchv:fix/SIGPIPE
Merged
fix: gracefully handle SIGPIPE#236Secrus merged 1 commit intopython-poetry:mainfrom branchv:fix/SIGPIPE
Secrus merged 1 commit intopython-poetry:mainfrom
branchv:fix/SIGPIPE
Conversation
dimbleby
reviewed
Aug 25, 2022
Member
|
I think this could resolve #56, could you confirm? |
dimbleby
approved these changes
Sep 2, 2022
Secrus
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fixing #234, I noticed cleo's terminal prompt wasn't rendering until after reading a response:
This was introduced via #165, since now we aren't always flushing the output. This reverts that and instead suppresses a broken pipe error, which was the initial motivation for that PR.
Note that
clickalso always flushes output and similary ignores broken pipes.I manually tested this with
poetry -V | head -1Closes #56