chore(typing): Add mypy to dependencies and move running it outside pre-commit

.github/workflows/tests.yml

@@ -72,6 +72,10 @@ jobs:
         run: |
           poetry install
 
+      - name: Run typechecking
+        run: |
+          poetry run mypy
+
       - name: Run tests
         run: |
           poetry run pytest -q tests

.pre-commit-config.yaml

@@ -47,11 +47,3 @@ repos:
     hooks:
       - id: flake8
         additional_dependencies: *flake8_deps
-
-  - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.982
-    hooks:
-      - id: mypy
-        pass_filenames: false
-        additional_dependencies:
-          - pytest>=7.1.2

pyproject.toml

@@ -28,7 +28,7 @@ classifiers = [
 # Requirements
 [tool.poetry.dependencies]
 python = "^3.7"
-crashtest = "^0.4.0"
+crashtest = "^0.4.1"
 rapidfuzz = "^2.2.0"
 
 [tool.poetry.group.dev.dependencies]
@@ -37,6 +37,7 @@ pytest-mock = "^3.8.2"
 pre-commit = "^2.20.0"
 pytest-cov = "^3.0.0"
 tox = "^3.25.1"
+mypy = "^0.982"
 
 [tool.poetry.group.doc.dependencies]
 Sphinx = "^5.2.3"

src/cleo/commands/command.py

@@ -14,7 +14,12 @@
 
 
 if TYPE_CHECKING:
-    from typing import Literal
+    import sys
+
+    if sys.version_info >= (3, 8):
+        from typing import Literal
+    else:
+        from typing_extensions import Literal
 
     from cleo.io.inputs.argument import Argument
     from cleo.io.inputs.option import Option

src/cleo/ui/exception_trace.py

@@ -259,14 +259,15 @@ def render(self, io: IO | Output, simple: bool = False) -> None:
 
         self._render_solution(io, self._exception)
 
-    def _render_exception(self, io: IO | Output, exception: Exception) -> None:
+    def _render_exception(self, io: IO | Output, exception: BaseException) -> None:
         from crashtest.inspector import Inspector
 
         inspector = Inspector(exception)
         if not inspector.frames:
             return
 
         if inspector.has_previous_exception():
+            assert inspector.previous_exception is not None  # make mypy happy
             self._render_exception(io, inspector.previous_exception)
             io.write_line("")
             io.write_line(

src/cleo/ui/table_cell_style.py

@@ -5,7 +5,12 @@
 
 
 if TYPE_CHECKING:
-    from typing import Literal
+    import sys
+
+    if sys.version_info >= (3, 8):
+        from typing import Literal
+    else:
+        from typing_extensions import Literal
 
     _Align = Union[Literal["left"], Literal["right"]]
 

tests/fixtures/exceptions/solution.py

@@ -2,8 +2,7 @@
 from crashtest.contracts.provides_solution import ProvidesSolution
 
 
-# mypy fails here because crashtest is not typed.
-class CustomError(ProvidesSolution, Exception):  # type: ignore
+class CustomError(ProvidesSolution, Exception):
     @property
     def solution(self) -> BaseSolution:
         solution = BaseSolution("Solution Title.", "Solution Description")

tests/ui/test_exception_trace.py

@@ -288,13 +288,13 @@ def test_render_supports_solutions() -> None:
 
   Error with solution
 
-  at {trace._get_relative_file_path(solution.__file__)}:17 in call
-       13│         return solution
+  at {trace._get_relative_file_path(solution.__file__)}:16 in call
+       12│         return solution
+       13│ 
        14│ 
-       15│ 
-       16│ def call() -> None:
-    →  17│     raise CustomError("Error with solution")
-       18│ 
+       15│ def call() -> None:
+    →  16│     raise CustomError("Error with solution")
+       17│ 
 
   • Solution Title: Solution Description
     https://example.com,
@@ -325,13 +325,13 @@ def test_render_falls_back_on_ascii_symbols() -> None:
 
   Error with solution
 
-  at {trace._get_relative_file_path(solution.__file__)}:17 in call
-       13|         return solution
+  at {trace._get_relative_file_path(solution.__file__)}:16 in call
+       12|         return solution
+       13| 
        14| 
-       15| 
-       16| def call() -> None:
-    >  17|     raise CustomError("Error with solution")
-       18| 
+       15| def call() -> None:
+    >  16|     raise CustomError("Error with solution")
+       17| 
 
   * Solution Title: Solution Description
     https://example.com,