Skip to content

feat(stream_output): respect FORCE_COLOR#343

Merged
Secrus merged 2 commits intopython-poetry:mainfrom
branchv:force-color
Nov 25, 2024
Merged

feat(stream_output): respect FORCE_COLOR#343
Secrus merged 2 commits intopython-poetry:mainfrom
branchv:force-color

Conversation

@branchv
Copy link
Copy Markdown
Member

@branchv branchv commented Jul 15, 2023

Closes #341

@trag1c
Copy link
Copy Markdown
Member

trag1c commented Jul 17, 2023

What do you think about including a warning when both NO_COLOR and FORCE_COLOR are supplied (like build does)? 🤔

@Secrus
Copy link
Copy Markdown
Member

Secrus commented Jul 17, 2023

What do you think about including a warning when both NO_COLOR and FORCE_COLOR are supplied (like build does)? 🤔

I agree, there should be a warning message (even if only for debugging purposes).

@adam-grant-hendry
Copy link
Copy Markdown

adam-grant-hendry commented Aug 23, 2023

Question: Is this intended to replace the ANSICON environment variable option?

@adam-grant-hendry adam-grant-hendry mentioned this pull request Aug 24, 2023
Closed
@Secrus Secrus merged commit af5eb92 into python-poetry:main Nov 25, 2024
@branchv branchv deleted the force-color branch December 1, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Secrus Secrus Secrus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support FORCE_COLOR env var

4 participants

@branchv @trag1c @Secrus @adam-grant-hendry