Skip to content

fix: properly complete subcommands for fish#358

Merged
Secrus merged 3 commits intopython-poetry:mainfrom
branchv:fish-completions
Oct 25, 2023
Merged

fix: properly complete subcommands for fish#358
Secrus merged 3 commits intopython-poetry:mainfrom
branchv:fish-completions

Conversation

@branchv
Copy link
Copy Markdown
Member

@branchv branchv commented Aug 21, 2023

Fixes #84
Fixes #359
Fixes #231
Fixes #366

@branchv branchv requested a review from Secrus August 21, 2023 09:16
Comment thread src/cleo/commands/completions_command.py
@Secrus
Copy link
Copy Markdown
Member

Secrus commented Aug 21, 2023

Having an example here, would you be able/willing to add subcommands for ZSH as well? I think we can skip bash since making subcommands completions in bash is a real pain based on my research.

@branchv
Copy link
Copy Markdown
Member Author

branchv commented Aug 22, 2023

Yea I'll look into zsh, might be a few days before I can get back to this

@Secrus Secrus mentioned this pull request Oct 25, 2023
@Secrus Secrus enabled auto-merge (squash) October 25, 2023 13:37
@Secrus Secrus merged commit f2b8075 into python-poetry:main Oct 25, 2023
@branchv branchv deleted the fish-completions branch October 30, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants