Skip to content

Enable hash checking again (currently hashes from lock file are not validated at all) #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FlorianLudwig wants to merge 2 commits into from
Closed

Enable hash checking again (currently hashes from lock file are not validated at all) #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cef19e
allow specifying hash type in FileDependency.hash
FlorianLudwig Nov 26, 2020
498ba71
ensure list of files is cloned
FlorianLudwig Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions poetry/core/packages/file_dependency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ def full_path(self):
def is_file(self):
return True

def hash(self):
h = hashlib.sha256()
def hash(self, name="sha256"):
h = hashlib.new(name)
Comment on lines -66 to +67
Copy link
Copy Markdown
Contributor

@0xDEC0DE 0xDEC0DE Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the docs say the named constructors are faster and should be preferred, and this doesn't do anything to address the issue. It can be safely dropped from the PR.

with self._full_path.open("rb") as fp:
for content in iter(lambda: fp.read(io.DEFAULT_BUFFER_SIZE), b""):
h.update(content)
Expand Down
1 change: 1 addition & 0 deletions poetry/core/packages/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ def clone(self): # type: () -> "Package"
clone.extras = self.extras
clone.root_dir = self.root_dir
clone.develop = self.develop
clone.files = self.files
Copy link
Copy Markdown
Contributor

@0xDEC0DE 0xDEC0DE Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be the "secret sauce" to get signature verification working.


for dep in self.requires:
clone.requires.append(dep)
Expand Down