respect format for explicit included files when finding excluded files#228
Merged
finswimmer merged 1 commit intoNov 9, 2021
Merged
Conversation
finswimmer
force-pushed
the
issue/4771-include-excluded
branch
from
d172d1c to
d65b4de
Compare
3 tasks
neersighted
approved these changes
Nov 5, 2021
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
Pretty elegant and the test case is good. LGTM!
nylocx
added a commit
to nylocx/poetry-cython-demo
that referenced
this pull request
Dec 23, 2021
Only exclude to reproduce the bug without needing python-poetry/poetry-core#228
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of finding excluded files, does not respect the given build format when removing an explicit included file from the excluded file list. This PR fixes this.
Resolves: python-poetry/poetry#4711