Refactor typing in version.pep440.segments#229
Closed
danieleades wants to merge 1 commit into
Closed
Conversation
danieleades
commented
Nov 13, 2021
Comment on lines
+34
to
+36
| # (this appears to trigger a mypy false positive) | ||
| extra: Union[int, Tuple[int, ...]] = dataclasses.field( # type: ignore | ||
| default_factory=tuple, compare=False |
Contributor
Author
There was a problem hiding this comment.
can i get a quick sanity check here @neersighted?
branchv
reviewed
Nov 14, 2021
danieleades
force-pushed
the
refactor/typing/version.pep440.segments
branch
4 times, most recently
from
76329fa to
548f973
Compare
danieleades
force-pushed
the
refactor/typing/version.pep440.segments
branch
from
548f973 to
42c045d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is stacked on top of #199, so i'll leave it as a draft until that's merged
addresses the type errors in
version.pep440.segments, and narrows the whitelist