special case union of single marker with inverse#255
Merged
neersighted merged 1 commit intopython-poetry:masterfrom Jan 27, 2022
Merged
special case union of single marker with inverse#255neersighted merged 1 commit intopython-poetry:masterfrom
neersighted merged 1 commit intopython-poetry:masterfrom
Conversation
Contributor
Author
|
Is "Poetry Downstream Tests" new? The first failure I think is a consequence of af08f1c; and the second failure is of course the point of this fix. |
Member
|
The Downstream tests are not new per-se. I think what we should do is 1. PR a fix for the |
To avoid ending up with constraints like: bar==7.8.9; platform_system != 'Windows' or platform_system == 'Windows'
dimbleby
force-pushed
the
union-with-inverse
branch
from
9d54aee to
fab8967
Compare
|
SonarCloud Quality Gate failed.
|
|
Kudos, SonarCloud Quality Gate passed!
|
neersighted
reviewed
Jan 25, 2022
radoering
approved these changes
Jan 25, 2022
neersighted
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid ending up with constraints like:
bar==7.8.9; platform_system != 'Windows' or platform_system == 'Windows'
Resolves: python-poetry#
Per comment at python-poetry/poetry#4824 (comment).
I have verified that this has the desired effect in the testcase added at python-poetry/poetry#4686