sort package name in extras to make it reproducible#280
Merged
Conversation
ali5h
force-pushed
the
poetry-issue-5125
branch
from
347bbeb to
e6145c4
Compare
finswimmer
requested changes
Feb 3, 2022
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution 👍
Can you please add some tests that cover the changes?
ali5h
force-pushed
the
poetry-issue-5125
branch
from
e6145c4 to
ccc8a1f
Compare
Contributor
Author
|
added |
ali5h
force-pushed
the
poetry-issue-5125
branch
from
ccc8a1f to
6bb8add
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
finswimmer
approved these changes
Feb 4, 2022
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Thanks a lot. Looks good to me 🚀
Merged
2 tasks
DavidVujic
pushed a commit
to DavidVujic/poetry-core
that referenced
this pull request
Mar 26, 2022
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this pull request
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#5125