Skip to content

Improve constraint union#283

Merged
finswimmer merged 3 commits into
python-poetry:masterfrom
radoering:improve-constraint-union
Feb 26, 2022
Merged

Improve constraint union#283
finswimmer merged 3 commits into
python-poetry:masterfrom
radoering:improve-constraint-union

Conversation

@radoering
Copy link
Copy Markdown
Member

@radoering radoering commented Feb 5, 2022

Preliminary step for improving the union of markers.

Allows the following new simplifications:

Constraint("win32").union(Constraint("win32")) == Constraint("win32")
Constraint("win32").union(Constraint("linux", "!=")) == Constraint("linux", "!=")
Constraint("win32", "!=").union(Constraint("linux")) == Constraint("win32", "!=")
Constraint("win32", "!=").union(Constraint("linux", "!=")) == AnyConstraint()

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@radoering radoering requested a review from a team February 6, 2022 14:08
@dimbleby dimbleby mentioned this pull request Feb 9, 2022
Merged
@radoering radoering mentioned this pull request Feb 11, 2022
Closed
@finswimmer finswimmer merged commit 4c17193 into python-poetry:master Feb 26, 2022
DavidVujic pushed a commit to DavidVujic/poetry-core that referenced this pull request Mar 26, 2022
@radoering @DavidVujic
Improve constraint union (python-poetry#283)
d6baff3 
* Refactoring in preparation to increase coverage by adding additional tests

* Increase test coverage for constraint intersection

* Improve constraint union
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
@radoering @bostonrwalker
Improve constraint union (python-poetry#283)
3483c2d 
* Refactoring in preparation to increase coverage by adding additional tests

* Increase test coverage for constraint intersection

* Improve constraint union
@radoering radoering deleted the improve-constraint-union branch November 24, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radoering @finswimmer