Constraint intersection#297
Merged
neersighted merged 3 commits intoFeb 28, 2022
Merged
Conversation
radoering
requested changes
Feb 26, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
Feb 27, 2022
neersighted
approved these changes
Feb 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry#
I noticed that the implementation of intersection on the
UnionConstraintwas treating the intersection with aMultiConstraintin exactly the same way as the intersection with anotherUnionConstraint.Well that can't be right, different inputs should give different outputs. Here's a fix.