Skip to content

Fix an issue where dependencies with an epoch are parsed as empty#316

Merged
abn merged 1 commit intopython-poetry:masterfrom
radoering:fix-dependencies-with-epoch-empty
Apr 2, 2022
Merged

Fix an issue where dependencies with an epoch are parsed as empty#316
abn merged 1 commit intopython-poetry:masterfrom
radoering:fix-dependencies-with-epoch-empty

Conversation

@radoering
Copy link
Copy Markdown
Member

  • remove duplicated and buggy method of first_pre_release() and use correct method first_prerelase()

Resolves: python-poetry/poetry#5374

  • Added tests for changed code.
  • Updated documentation for changed code.

@radoering radoering force-pushed the fix-dependencies-with-epoch-empty branch from d9df789 to bfabd4f Compare April 1, 2022 16:30
@radoering radoering requested a review from a team April 1, 2022 16:43
Copy link
Copy Markdown
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion.

Comment thread tests/semver/test_helpers.py Outdated
* remove duplicated and buggy method of first_pre_release() and use correct method first_prerelase()
@radoering radoering force-pushed the fix-dependencies-with-epoch-empty branch from bfabd4f to 93b773f Compare April 2, 2022 08:54
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

@abn abn merged commit d7b5572 into python-poetry:master Apr 2, 2022
@finswimmer finswimmer mentioned this pull request May 20, 2022
@radoering radoering deleted the fix-dependencies-with-epoch-empty branch November 24, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poetry reads pypi dependencies' dependencies with epoch version as <empty>

2 participants