chore(tests): remove type errors#338
Merged
Merged
Conversation
branchv
commented
May 1, 2022
| dependency = Dependency("foo", "^1.2.3") | ||
|
|
||
| dependency.marker = 'python_version >= "3.6" and python_version < "4.0"' | ||
| dependency.marker = 'python_version >= "3.6" and python_version < "4.0"' # type: ignore[assignment] |
Member
Author
There was a problem hiding this comment.
this is an issue with marker's setter accepting the union str | BaseMarker and mypy not being able to understand: python/mypy#3004
branchv
commented
May 1, 2022
|
|
||
| [[tool.mypy.overrides]] | ||
| module = ['tests.*'] | ||
| disallow_untyped_decorators = false |
Member
Author
There was a problem hiding this comment.
this is only disabled due to pytest not currently being in mypy's environment
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
May 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
testsfrom mypy's ignored listThe first commit 9f8ffc2 fixes type issues, while the second 81bfebd just adds explicit return types
-> None