Add "authors" as a required field in config schema#37
Closed
rpdelaney wants to merge 1 commit into
Closed
Conversation
Before this change, a pyproject.toml file without an "authors" field would throw an unhandled `NonExistentKey` exception. Now it will be returned as a config validation error, as with the "name", "version", and "description" fields.
2 tasks
Author
|
@abn Is this the right place ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen here
Before this change, a pyproject.toml file without an "authors" field would throw an unhandled
NonExistentKeyexception. Now it will be returned as a config validation error, as with the "name", "version", and "description" fields.Before
After
Pull Request Check List
I didn't do this, because:
test_factory.pyline 184, but adding a line with- 'authors' is a required propertybroke a whole lot of other tests.I'd be happy to add a test but I will need either more time or a bit of guidance.
I don't believe this is applicable.