Skip to content

remove Package.requires_extras#374

Merged
abn merged 1 commit intopython-poetry:mainfrom
dimbleby:no-requires-extras
May 26, 2022
Merged

remove Package.requires_extras#374
abn merged 1 commit intopython-poetry:mainfrom
dimbleby:no-requires-extras

Conversation

@dimbleby
Copy link
Copy Markdown
Contributor

If and when python-poetry/poetry#5688 is merged, there'll be no use for this field.

(Even today there is no good use for this field)

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abn
Copy link
Copy Markdown
Member

abn commented May 25, 2022

I suspect the usage in Poetry at https://github.com/python-poetry/poetry/blob/a13ccf887057445560c8302f3c0668d1a49a524e/src/poetry/packages/locker.py#L373 should be replaced prior to merging this.

Just realised the PR has removed this already.

@abn abn requested a review from a team May 25, 2022 21:05
@abn abn merged commit 97ab42c into python-poetry:main May 26, 2022
@dimbleby dimbleby deleted the no-requires-extras branch May 26, 2022 21:32
@radoering radoering mentioned this pull request Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants