Skip to content

Allow : in Author name.#411

Merged
neersighted merged 8 commits intopython-poetry:mainfrom
Amourspirit:qname
Sep 3, 2022
Merged

Allow : in Author name.#411
neersighted merged 8 commits intopython-poetry:mainfrom
Amourspirit:qname

Conversation

@Amourspirit
Copy link
Copy Markdown
Contributor

@Amourspirit Amourspirit commented Jul 5, 2022 •
edited
Loading

Suport for names such as :Barry-Thomas-Paul: Moss
See: FOR THE CLAIM OF THE LIFE.

Resolves: python-poetry#

  • Added tests for changed code.
  • Updated documentation for changed code.

@neersighted
Copy link
Copy Markdown
Member

neersighted commented Jul 25, 2022

I'm really unclear on the purpose or value of this (and the linked site seems to be a combo of a sovereign citizen/world citizen/law of attraction sort of thing) -- but setuptools allows it, so I suppose we might as well.

It looks like we don't have any test coverage here -- could you please write a test with good and bad names?

neersighted
neersighted requested changes Jul 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires tests.

@Amourspirit
Copy link
Copy Markdown
Contributor Author

Amourspirit commented Jul 26, 2022

I'm really unclear on the purpose or value of this (and the linked site seems to be a combo of a sovereign citizen/world citizen/law of attraction sort of thing) -- but setuptools allows it, so I suppose we might as well.

It looks like we don't have any test coverage here -- could you please write a test with good and bad names?

Short version Poetry is blocking my Lawful name.

@Amourspirit
Copy link
Copy Markdown
Contributor Author

Amourspirit commented Jul 26, 2022

Requires tests.

All current test are passing. I will add specific test and update PR.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Secrus Secrus requested a review from neersighted August 27, 2022 19:56
@neersighted neersighted merged commit e3ea1b1 into python-poetry:main Sep 3, 2022
@radoering radoering mentioned this pull request Sep 13, 2022
Merged
@Amourspirit Amourspirit deleted the qname branch September 24, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neersighted neersighted neersighted approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Amourspirit @neersighted @Secrus