Skip to content

Make poetry check detect missing authors property#437

Merged
Secrus merged 4 commits into
python-poetry:mainfrom
stinodego:check-authors
Aug 22, 2022
Merged

Make poetry check detect missing authors property#437
Secrus merged 4 commits into
python-poetry:mainfrom
stinodego:check-authors

Conversation

@stinodego
Copy link
Copy Markdown

@stinodego stinodego commented Aug 3, 2022

Resolves: python-poetry/poetry#4303

  • Added tests for changed code.

Changes:

  • Updated the poetry-schema.json to add authors to the 'required' section
  • Updated tests as required

Note that python-poetry/poetry#6112 must be merged before the downstream tests for this PR will pass.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Secrus Secrus merged commit c9348e8 into python-poetry:main Aug 22, 2022
@Secrus Secrus mentioned this pull request Aug 22, 2022
2 tasks
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
)

* Add authors as required property

* Fix existing tests

Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poetry check does not detect missing authors property

2 participants