Skip to content

dependency: consider source_name in is_same_source_as#488

Closed
radoering wants to merge 1 commit into
python-poetry:mainfrom
radoering:dependency-is-same-source-as
Closed

dependency: consider source_name in is_same_source_as#488
radoering wants to merge 1 commit into
python-poetry:mainfrom
radoering:dependency-is-same-source-as

Conversation

@radoering
Copy link
Copy Markdown
Member

As per python-poetry/poetry#6679 (comment)

  • Added tests for changed code.
  • Updated documentation for changed code.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@radoering
Copy link
Copy Markdown
Member Author

Hmm, looking at the downstream tests perhaps not such a good idea after all. Have to take a closer look later.

@radoering
Copy link
Copy Markdown
Member Author

Discarding this for now because it breaks the heart of the dependency resolver. _compatible_dependency() compares dependencies with source_name with dependencies created from packages via to_dependency() which of course never have a source_name. Changing that would probably require a major refactoring.

@radoering radoering closed this Oct 2, 2022
@radoering radoering deleted the dependency-is-same-source-as branch November 24, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant