Skip to content

feat: add possibility to set the pyproject TOML on a Poetry instance#523

Closed
DavidVujic wants to merge 1 commit intopython-poetry:mainfrom
DavidVujic:setter_for_pyproject_file
Closed

feat: add possibility to set the pyproject TOML on a Poetry instance#523
DavidVujic wants to merge 1 commit intopython-poetry:mainfrom
DavidVujic:setter_for_pyproject_file

Conversation

@DavidVujic
Copy link
Copy Markdown

Resolves part one of: python-poetry#7039

  • Added tests for changed code.
  • Updated documentation for changed code.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@neersighted
Copy link
Copy Markdown
Member

neersighted commented Nov 15, 2022

I think this is an inferior duplicate of python-poetry/poetry#6810 (it's not necessary to add special support for overriding the project file as there are other places in the code that assume its location at the root of the project, and we can set CWD instead as in that PR).

@DavidVujic
Copy link
Copy Markdown
Author

I think this is an inferior duplicate of python-poetry/poetry#6810 (it's not necessary to add special support for overriding the project file as there are other places in the code that assume its location at the root of the project, and we can set CWD instead as in that PR).

Thank you for explaining and linking to the already ongoing work. I'll close this one!

@DavidVujic DavidVujic closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants