Make WheelBuilder easier to inherit from#855
Merged
Merged
Conversation
Reviewer's Guide by SourceryThis pull request modifies the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @MatthijsBurgh - I've reviewed your changes - here's some feedback:
Overall Comments:
- This change looks good, but it would be helpful to add a test case that specifically covers the inheritance scenario to ensure the
make_inmethod works as expected in derived classes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
radoering
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inheriting from WheelBuilder, I also have to overwrite the
make_inclassmethod. As it always creates aWheelBuilderinstead of using the current class. This small change doesn't affect your implementation. It just makes inheriting from it a little bit easier.Summary by Sourcery
Enhancements:
make_inclassmethod to usecls()instead of directly instantiating WheelBuilder, making the class more flexible for inheritance