Skip to content

pay attention to package sources in export#111

Merged
radoering merged 1 commit intopython-poetry:mainfrom
dimbleby:check-package-sources
Sep 2, 2022
Merged

pay attention to package sources in export#111
radoering merged 1 commit intopython-poetry:mainfrom
dimbleby:check-package-sources

Conversation

@dimbleby
Copy link
Copy Markdown
Contributor

@dimbleby dimbleby commented Sep 2, 2022

previously the exporter would see two packages from different sources as the same, combine their markers, and produce nonsense like this:

foo @ https://example.com/foo-darwin.whl ; python_version >= "3.6" and python_version < "4.0" and sys_platform == "linux" or python_version >= "3.6" and python_version < "4.0" and sys_platform == "darwin"

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@radoering radoering merged commit 7e6222f into python-poetry:main Sep 2, 2022
@dimbleby dimbleby deleted the check-package-sources branch September 2, 2022 18:55
@radoering radoering mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants