fix --with-credentials export of --extra-index-url lines#117
Merged
radoering merged 6 commits intopython-poetry:mainfrom Sep 10, 2022
Merged
fix --with-credentials export of --extra-index-url lines#117radoering merged 6 commits intopython-poetry:mainfrom
radoering merged 6 commits intopython-poetry:mainfrom
Conversation
Poetry 1.2.0 includes a change to `poetry.repositories.pool.Pool.remove_repository` that allows actually removing the PyPI repository. The test added by this branch needs to remove the default repository so it can add an alternate, custom repository.
Contributor
Author
|
Is there anything I can do to help move this PR along? I'm not sure how to fix the security hotspots (or if I need to -- they seem like false positives.) |
dimbleby
reviewed
Sep 10, 2022
Member
IMO, it's ok if we depend on the released version of poetry and do not support betas anymore in the next plugin release. Can please revert your lockfile change, update the dependencies in pyproject.toml for poetry and poetry-core to depend on the releases and run |
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
Sep 10, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #22.
The fix for this issue is to add a single character:
indexes_header = ...becomesindexes_header += ...within the loop that builds the--index-urland--extra-index-urllines of the exported text.I added a test case to demonstrate the problem and prove to myself that I'd fixed it.
I had to run
poetry lockto bump the poetry dependency to 1.2.0. The previously locked version, 1.2.0b3, didn't actually remove the PyPI repository frompoetry.poolwhen my new test calledpoetry.pool.remove_repository("PyPI"). The implementation of that method changed from 1.2.0b3 to 1.2.0 to address exactly that issue. If it's possible to add a different default repository with 1.2.0b3, I'm happy to revert thepoetry lockcommit and modify the test case.